Andy Gocke comments

Results 208 comments of


                                            Andy Gocke

Make TraceEvent and FastSerialization AOT-compatible

VS Code also has a setting if you're reviewing locally: `"diffEditor.ignoreTrimWhitespace": true`

Make TraceEvent and FastSerialization AOT-compatible

Great questions! Here are some useful resources: - https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-concepts Conceptual doc on how trimming works - https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/fixing-warnings Doc on fixing trim warnings For validation, I can create a project that...

error NU1004: The package reference Microsoft.NET.ILLink.Tasks version has changed from [8.0.14, ) to [8.0.15, ).

This looks to be a bug in the SDK. The ILLink.Tasks package is an implict package and shouldn't be included in the lock file.

error NU1004: The package reference Microsoft.NET.ILLink.Tasks version has changed from [8.0.14, ) to [8.0.15, ).

+ @sbomer as well. My understanding was that this was the recommended way to pull in extra resources for publish in the sdk. If it’s not, we could explore another...

`dotnet format` does not respect interceptors for Request Delegate Generator

@phil-allen-msft

GenerateBundle Task fails writing to singlefilehost.exe

@jtschuster can you take a look?

GenerateBundle Task fails writing to singlefilehost.exe

I'm going to load balance a bit. @sbomer can you look instead?

Introduce yaml variables file for shared tooling into eng/common

Specifically, I think the toolchain (OS + native build tools) should be locked between runtime and vmr