Anton Gilgur
Anton Gilgur
> I expected it for the parameter that I overrode, but not for the other parameters. Ah I gotcha now. Basically you're providing a default list in your WorkflowTemplate; so...
> Ok, wanted to make sure. At this point this thread is pretty windy, could you file a separate feature request for that to keep things tidy? I filed #13035...
Fixed merge conflicts
Well that's surprising, `qe-id` isn't a valid attribute on `input` elements (hence the lint error) and is a convention for tests... It shouldn't be used for any actual behavior at...
> Testing locally, it looks like this change breaks Argo CD's application list autocomplete. Even more confusingly, [CD's Application List](https://github.com/argoproj/argo-cd/blob/24ac326384b7939fa36d48e79cfa320528cf85e2/ui/src/app/applications/components/applications-list/applications-list.tsx#L228) uses the [`Autocomplete`](https://github.com/argoproj/argo-ui/blob/17d7a8be6aa2c0357f40bbe6856a1b2130806cd6/src/components/autocomplete/autocomplete.tsx) component, which did not change here (_not_...
> Like it pops up on #534 but not #536, despite neither of them changing any source code Figured out that was due to an accidental ESLint upgrade in #534's...
As the GitHub interface says, it requires an approval from a maintainer:  I [still](https://docs.google.com/document/d/1C71GA0XCxsyGP7Q4SYveHak5ZZcJOuaOiDCt_xHG10U/edit#heading=h.y5xnyirokxg4) do not have maintainer permissions for this repo, so I can't do anything. I'm also...
Yes, I had been planning to; I'm not sure why you asked several other uninvolved people [for review](https://github.com/argoproj/argo-ui/pull/546#issuecomment-2068031295) a day after you [made changes](https://github.com/argoproj/argo-ui/pull/546#discussion_r1573288510), which was a full 2 weeks...
No, you can see [the diff](https://github.com/argoproj/argo-ui/pull/546/files#diff-48cf7c1e882b0dbbd38bc060ea6838bffad15d57d406d8010295c711ac9536ad) for yourself here in the PR, which is all of 4 LoC of an in-line style that uses `overflow-wrap: break-word`. `word-break: break-word` is also...
Fixed merge conflicts with #509. There's a new warning during the install that seems to be because dependabot just merged #539 and #541 (they were created before #537 was merged),...