argo-ui
argo-ui copied to clipboard
chore(deps): upgrade to node v20
Supersedes / Closes #432
Motivation
- node v14 is EoL and has been since April 2023
- node v20 is the current LTS version
Modifications
-
update
.nvmrc
to Node v20 -
~update all
actions/setup-node
GH Actions to use the.nvmrc
for consistency~ EDIT: that ended up being completed as part of #509 -
due to an old version of Storybook / Webpack, we have to run all Storybook scripts with
NODE_OPTIONS='--openssl-legacy-provider'
- this must be used if we use newer versions of node without upgrading Storybook + Webpack
- unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and
antd
). See https://github.com/argoproj/argo-ui/pull/432#issuecomment-1879816619 noting my trials and tribulations with that- so put that off for now (or ever? since this repo is not maintained much anymore)
- potentially leave Storybook as-is and have it use Webpack v5? See also https://github.com/argoproj/argo-ui/issues/469#issuecomment-1879870424
- so put that off for now (or ever? since this repo is not maintained much anymore)
- unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and
- note that this is an insecure run-time configuration (which is why it was deprecated and is legacy), but since it is only used in development, it's not a significant vulnerability
- this must be used if we use newer versions of node without upgrading Storybook + Webpack
Verification
Install works, builds pass, tests pass
Future Work
- Storybook upgrade, maybe never
- Webpack upgrade, maybe doable. Then can remove
--openssl-legacy-provider
- Have dependabot stop updating deps with breaking changes... 😐
Fixed merge conflicts
Stale pull request message