argo-ui icon indicating copy to clipboard operation
argo-ui copied to clipboard

chore(deps): upgrade to node v20

Open agilgur5 opened this issue 1 year ago • 2 comments

Supersedes / Closes #432

Motivation

Modifications

  • update .nvmrc to Node v20

  • ~update all actions/setup-node GH Actions to use the .nvmrc for consistency~ EDIT: that ended up being completed as part of #509

  • due to an old version of Storybook / Webpack, we have to run all Storybook scripts with NODE_OPTIONS='--openssl-legacy-provider'

    • this must be used if we use newer versions of node without upgrading Storybook + Webpack
      • unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and antd). See https://github.com/argoproj/argo-ui/pull/432#issuecomment-1879816619 noting my trials and tribulations with that
        • so put that off for now (or ever? since this repo is not maintained much anymore)
          • potentially leave Storybook as-is and have it use Webpack v5? See also https://github.com/argoproj/argo-ui/issues/469#issuecomment-1879870424
    • note that this is an insecure run-time configuration (which is why it was deprecated and is legacy), but since it is only used in development, it's not a significant vulnerability

Verification

Install works, builds pass, tests pass

Future Work

  1. Storybook upgrade, maybe never
  2. Webpack upgrade, maybe doable. Then can remove --openssl-legacy-provider
  3. Have dependabot stop updating deps with breaking changes... 😐

agilgur5 avatar Feb 12 '24 21:02 agilgur5

Fixed merge conflicts

agilgur5 avatar Feb 14 '24 17:02 agilgur5

Stale pull request message

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]