argo-ui icon indicating copy to clipboard operation
argo-ui copied to clipboard

feat: #17436 Update dropdown-menu.tsx to have standard link behaviour

Open Hussain-Ruhullah opened this issue 11 months ago • 2 comments

Closes [ISSUE #17436] Screenshot 2024-03-07 130000

Hussain-Ruhullah avatar Mar 07 '24 12:03 Hussain-Ruhullah

Hello @agilgur5, how to make the build job run here?

Hussain-Ruhullah avatar Mar 08 '24 11:03 Hussain-Ruhullah

As the GitHub interface says, it requires an approval from a maintainer: Screenshot_2024-03-08-10-37-29-13_40deb401b9ffe8e1df2f1cc5ba480b12

I still do not have maintainer permissions for this repo, so I can't do anything. I'm also a Workflows maintainer, not a CD maintainer, so this PR would not necessarily fall under my purview either.

Closes [ISSUE #17436]

Also please use a full link to the CD issue: https://github.com/argoproj/argo-cd/issues/17436. A raw issue number does not work across different repositories. The proper GitHub syntax is also "Closes #x", not "Closes [ISSUE #x]"

agilgur5 avatar Mar 08 '24 15:03 agilgur5

Stale pull request message

github-actions[bot] avatar May 26 '24 11:05 github-actions[bot]

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.

github-actions[bot] avatar Jun 10 '24 02:06 github-actions[bot]