Anton Gilgur
Anton Gilgur
`lint` is weirdly [erroring](https://github.com/argoproj/argo-ui/actions/runs/7889119339/job/21528202750?pr=534) here but not in other PRs that similarly don't change source code... strange... Raised #543 for that since it's independent of this PR. Will have to...
> `lint` is weirdly [erroring](https://github.com/argoproj/argo-ui/actions/runs/7889119339/job/21528202750?pr=534) here but not in other PRs that similarly don't change source code... strange... > > Raised #543 for that since it's independent of this PR....
Rebased on top of / fixed merged conflicts with #534 now that it's been merged and marked this ready for review!
That was intentional, to match the `formatDuration` func, as I wrote in the PR description. Otherwise, as I wrote there, we could remove the component entirely
OHHH, did you mean the "Active for: 85d"? That does sound buggy and is _not_ equivalent to "02:00 hours" I didn't notice that initially (playing spot the difference as you...
Should be fixed now
> Looks okay but unable to run storybook locally, deps need updating See #469 with regard to the currently broken Storybook build 😕 #536 partially fixes that
Huh well that's more confusing... `sigfigs` was the only part I ignored, but that should result in `4d` and `4m` respectively. Floating point arithmetic is also imprecise, but not _that_...
I did some testing: ```js const minute = 60; const hour = minute * 60; const day = hour * 24; // spot checks console.log(formatDuration(20)); // 20s console.log(formatDuration(day)); // 24h...
> I guess I'll leave the buggy behavior for backward compat and add a JSDoc comment about this. Added JSDoc indication that looks like: ![Screenshot 2024-06-05 at 7 54 16 ...