Adam Gent

Results 165 comments of Adam Gent

@ceki I forgot to mention the level `ALL` is also broken and perhaps the bigger bug. I can put in an integration test module as a PR if you like...

@ceki I think out of the box JUL will not discard any events and is set to ALL. The issue is actually one of security and other libraries. Other libraries...

That is a third party library that is not your own very easily could have originally done: ```java var level = levelDeterminedFromSomeConfigInLibraryOrCondition; // level gets set to OFF jul.log(level, "hello");...

If you think JUL and System.Logger do not have a strong relationship in levels and behavior I suggest you examine the javadoc: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/System.Logger.Level.html > [System logger levels](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/System.Logger.Level.html) are mapped to...

> My initial premise regarding Level.OFF and Level.ON being unusable in regular log statement was incorrect as your examples clearly show. However, I think passing Level.OFF or Level.ON to a...

> As a ignorant developer supporting a library with OSGi users, I found adding a unit test helpful comfort, wdyt? ([example](https://github.com/ben-manes/caffeine/blob/master/caffeine/src/test/java/com/github/benmanes/caffeine/OSGiTest.java#L37-L52) using pax-exam) I'm going to steal that 😄 for...

@ben-manes Sorry I didn't mean for you to go actually check 😄 just if you knew offhand. Thanks for checking though! The reason is because it is missing from :...

The fact that MapStruct does not handle `@Nullable` annotations particularly `TYPE_USE` aka JSR 308 annotations (e.g. JSpecify and Checker) is a major reason I have the generator run and just...

> I am not sure that MapStruct should treat methods with types annotated differently as different types. I would rather have MapStruct properly detect NonNull / Nullable annotations and invoke...

Hi guys. I was the one I think that lead @bowbahdoe down this path and I'm glad they filed the JDK bug. Anyway I suddenly found a need for properly...