Adam Gent

Results 165 comments of Adam Gent

@bertramn and @jknack Here is a trivial, and Java Bean Compliant Value Resolver: ```java import java.beans.Introspector; import java.lang.reflect.Method; import com.github.jknack.handlebars.context.JavaBeanValueResolver; public class CustomHandlebarsBeanValueResolver extends JavaBeanValueResolver { public static final CustomHandlebarsBeanValueResolver...

See #940 In this class: https://github.com/OpenAPITools/openapi-generator/blob/4d947a1c4579a73c7350ea55153d33ef76ba5d89/modules/openapi-generator/src/main/java/org/openapitools/codegen/templating/HandlebarsEngineAdapter.java Change the FieldValueResolver to something like: ```java var MY_FIELD_VALUE_RESOLVER = new FieldValueResolver() { @Override protected Set members( Class clazz) { var members = super.members(clazz);...

@jkissel I think you are confusing some things. Handlebars.java is pure Java. It only dispatches to the Javascript Engine if and only if you want to use Javascript helpers. Thus...

If we pull your change in we break templates for folks upgrading in possibly very bizarre and not easy to understand ways (see #951 and the plethora of other recent...

The default value resolvers are different when using different JDKs. See https://github.com/jknack/handlebars.java/blob/master/handlebars/src/main/java/com/github/jknack/handlebars/ValueResolver.java#L87 @jknack This changed seemed to cause lots of confusion. Maybe some doc needs to be added.

> There is a Java API you can use to create your dbEnvironment and execute the deployment, without a system-config.xml. I can point you to that doc, though I understand...

At an abstract level I'm basically saying Class types that come in as an empty String more often than not probably should be null. Which actually brings up three conditions:...

I think the only reactive support that should be provided is JDK 9 Flow. All the reactive libraries have bridges to JDK 9 Flow and it seems reasonable to support...

Yes sadly I don't think this can be fixed to till 3.0 See #2325 And you can see the fix here where basically it was decided to do a precedence...

Also to add to your work arounds and I believe this is what we do in some places: ```java record FooList(List foo) {} ``` ```java class FooController { public void...