Adam Gent

Results 165 comments of Adam Gent

One technique to the whole Java 17 issue that I have used several times is to use the ServiceLoader pattern. Write the ED part as a separate jar and if...

I was just looking at trying to use Edwards Curve and it is only supported in Java 15 or greater https://openjdk.org/jeps/339 I have contemplated forking this project to get it...

Oh it looks like `RockerRuntime` is the only place logging is done and there are only like 3 calls.... so maybe there is a simpler solution.

I'm thinking maybe we could just check if rocker-compiler is in the classpath and then use slf4j but that still requires some wrapper. I'll try to come up with something...

@ceki maybe. I'll have to test but my gut is no because the issue is if the library to be compiled is using the ServiceLoader I think you run into...

@jjlauer Let me know what you think of the fix. If it looks good I can squash the commits.

> @agentgt SLF4J 1.8 and 2.0 use ServiceLoader. Will this solve the issue your are raising? @ceki I think the new SLF4J that uses the ServiceLoader will work if I...

@ceki Since I'm shading the annotation processor now I can use any slf4j I want to so I picked 1.8 beta which uses the ServiceLoader and I got it to...

I'm just lurking here but I do like @bendem solution albeit it tightly couples your code with Rocker (via RockerModel). I think a type level Annotation on plain POJO's would...

@jjlauer In theory you can easily make the rocker maven plugin compatible with m2e (eclipse maven) without requiring library consumers to do the configuration that @jknack did by just following...