Adam Gent

Sorry @jknack I didn’t follow up on this. I have will try to test the new change this week before I go on vacation.

Sorry I missed this comment. I think if it is event-loop it is fine. I assume we would just make an abstraction so that the encoder does not have to...

Here is Spring's BTW: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/core/codec/Encoder.html Massively overcomplicated as usual for Spring (and surprisingly not very abstract as you have to use Reactor). JStachio's implementation from Spring WebFlux is here: https://github.com/jstachio/jstachio/blob/main/opt/jstachio-spring-webflux/src/main/java/io/jstach/opt/spring/webflux/JStachioEncoder.java...

@gunnarmorling Take a look at: https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3 Specifically the thread safety checklist. ~~I took a very quick glance ripgrepping the code looking for any mutable static singletons and I could not...

Actually this might be problematic but problematic in general depending on what happens with class loading: https://github.com/moditect/moditect/blob/56fdfc2ef89ed9ba4b04e8a57815464709ad9b03/core/src/main/java/org/moditect/internal/compiler/ModuleInfoCompiler.java#L50 EDIT Apparently if you use that you should restore the configuration as it...

`GenerateModuleInfo` also uses `StaticJavaParser`. This is potentially problematic but in practice I'm not sure. Maybe it is shaded in moditect? Regardless `GenerateModuleInfo` could be called before `ModuleInfoCompiler` in which case...

@gunnarmorling I can probably look into next month. I'm rather slammed myself.

FWIW the times I have used `null` in exception constructors has always been calling the `super` from an inherited constructors and often it is a protected constructor. So I think...

@fstab and others I was just reviewing the prometheus HTTP server code as well and noticed the ByteArrayOutputStream albeit in 1.0.0 there is no threadlocal. I'm using Jooby which allows...

> @agentgt Can you create a LogRecord with the Level.OFF as the level? I don't think that is possible or is it? Oh it is possible that is how I...