Andrew Duthie
Andrew Duthie
Ah, yeah, I see the issue now. On first glance, I'd wonder if it'd be fine enough to swap out `null` with `this`, but I'd need to write some tests...
If it's useful for reference, we had migrated off pa11y to HTML_CodeSniffer in our project in https://github.com/18F/identity-design-system/pull/285 , though (a) we already had an integrated browser driver to fall back...
The code for this project is now managed in GitLab, so this pull request will need to be recreated there if there's still interest in it. https://gitlab.login.gov/lg/identity-pki/-/merge_requests/new
I don't think this has to be a breaking change. A transitionary step could be to write ESM by default, but continue to compile and distribute a CommonJS version. Backward...
The build failure seems to be unrelated to the changes here, starting in #5233 and affecting [all commits on `develop` since](https://github.com/uswds/uswds/commits/develop/) and [other pull requests](https://github.com/uswds/uswds/pull/5794). **Edit:** See fix at #5795
> * **Smaller PR's.** Breaking out the work helps us reliably and quickly test one thing at a time, which we may need to do over multiple sprints, in order...
Closing in favor of smaller, targeted pull requests. I've also incorporated the review feedback into those pull requests. It also occurred to me that one of the reasons for making...
>Allow developers who have a custom implementation the option to easily remove label . To support this, and continuing my original comment's context of our needing to support multilingual labels,...
> As a developer, I expect that if I include the package listed on a component's documentation (e.g. [Text Input](https://designsystem.digital.gov/components/text-input/)), all of the usage options documented for that component are...
That's a good catch @amyleadem ! I'll plan to patch that up.