Andrew Duthie

Results 98 comments of Andrew Duthie

It looks like the changes here may have introduced an accessibility build failure which is causing other pull requests to fail. **Edit:** See fix at #5795 ``` 1) Components/Validation Textarea...

Some more data points: The ARIA spec discourages the use of redundant ARIA attributes: >It is NOT RECOMMENDED for authors to set the ARIA role and `aria-*` attributes to values...

Any update on when this will be worked on? We can also reopen closed pull requests.

Are these changes still needed or can this pull request be closed?

Hi @mcsf @rlankhorst ! As one of the people who helps maintain parts of the data module, I thought I'd drop in and share a few of my own thoughts....

@garretthyder Great! I added it to [the agenda](https://docs.google.com/document/d/1BTZMiff0HtkMNCJNoBI_tAHmPFYHY3BWIcQiAVoQDPE/edit) for tomorrow's chat at 14:00 UTC. If that's too soon and there's nobody who can attend, we can punt it to next...

👋 There's some prior art to this with the `time-remaining` and `disable-nux` plugins installed by default as `mu-plugins`: https://github.com/WordPress/gutenberg.run/blob/1e9211fc209ed76d81f80904c2e22b1abf70b3ed/images/gutenbergrun-site/Dockerfile#L29-L30 Those are pretty simple examples though, since they're single file plugins....

This is ready for review now. I've also tested this against real reCAPTCHA Enterprise which revealed some necessary changes in c0ef243, but worked successfully afterward. Let me know if you'd...

I expect the [`identity-rails-i18n-webpack-plugin` JavaScript package](https://github.com/18F/identity-idp/tree/main/app/javascript/packages/rails-i18n-webpack-plugin) will need some updates here as well, since it's currently implemented to read the YAML files.