Andrew Duthie
Andrew Duthie
Also, I think migrating to the standard ruleset is probably a good idea to bring this configuration closer in line with the TTS Engineering guidelines, which also recommend this ruleset:...
Good idea. Maybe we can configure all the rules as [`warning` severity](https://stylelint.io/user-guide/configure#severity) in a minor release as a deprecation path, and then plan to switch them to `error` severity in...
After spending a little time with trying to create a deprecation path, I realized it's going to be a substantial effort to list and override each additional rule to be...
>1. Add { resolveNestedSelectors: true } option to selector-class-pattern and publish in a minor release (4.1.0) >2. Replace `stylelint-config-recommended-scss` with `stylelint-config-standard-scss` and publish in a beta major release (5.0.0-beta.1) These...
>LGTM! So glad that this small number analytics events could allow removing this exception from a those tests! It could have been that there have been other changes on `main`...
Potential avenues to explore as a solution: - Add coverage to some or all of the behaviors noted above (e.g. consider `tabindex="-1"`) - Or, use a third-party library like `focus-trap`...
> I'm curious about the real-world implications of this behavior. For modals, we recommend **not** nesting [multi-step processes](https://designsystem.digital.gov/components/modal/) within modal windows. When would a user likely come across this behavior?...
Seems like a fix may just be to invert the condition for passing `--no-save`: ```js const args = ['npm', 'install', name] if (opts.save !== true) { args.push('--no-save') opts.save = null...
> It may be possible to configure or override the default value, though it is currently configured as a module constant `ActionView::Helpers::AssetTagHelper::MAX_HEADER_SIZE`. The changelog note about "diminishing returns" is a...
I'm not sure I follow the concern. Could you provide a sample code snippet of a `memize`-memoized function result which demonstrates the issue?