Andrew Duthie

`i18n_spec.rb` includes [a `flatten_hash` helper](https://github.com/18F/identity-idp/blob/c2847c7c59598a45d1fff7bed0a220cfd8af212b/spec/i18n_spec.rb#L453-L464) which I assume will be unnecessary after these changes. Could save for a follow-on pull request to reduce the scope here.

I'm guessing we don't need all of the revisions from the tracking spreadsheet because those were updated in #10323, is that right?

Since #10291 is now merged, can we rebase this and add Chinese translations? The build may fail without them as well.

Hi @h-m-f-t , thanks for your feedback on this new feature! I think you raise a valid point, and at the very least I feel that the content should more...

Just wanted to drop a quick follow-up that this is now implemented in production: a user will only be recommended a PIV/CAC as part of user creation if they're signing...

Unfortunately, I think this behavior may already be implemented, stemming back to @mitchellhenke's comment in https://github.com/18F/identity-idp/pull/10459#discussion_r1571044675 . It's a little non-obvious, especially since it happens through the `TwoFactorAuthenticationController` controller, which...

@anselmbradford Thanks for the pointers and feedback! I'll plan to review these soon, and will follow-up by end-of-day tomorrow.

Some initial impressions before I look to make some changes here based on your feedback. Let me know what you think! > * The latest stylelint has deprecated commonjs and...

Yeah, the way we currently [assign exports](https://github.com/18F/identity-idp/blob/c8106fc4e43548929839b5200fd02c62adf5be11/app/javascript/packages/stylelint-config/package.json#L6-L8) would prevent people from being able to reference the file directly from within the package. In other words, only `import '@18f/identity-stylelint-config';` is supported,...

I spent some time trying out replacing `stylelint-config-recommended-scss` with `stylelint-config-standard-scss` in this project. It caught a lot of new issues (97 errors) which would likely create a burden for downstream...