Andrew Duthie

Glad to see this land 🎉 Already with the changes included in this pull request, the strong typing is already looking to prove itself quite valuable. Major props to all...

> Hmm, This could be fixed by either adding an optional chaining to `tannin/sprintf` or by adding a variable check in `@wordpress/i18n`'s sprintf. If I understand, the issue is specifically...

Another thought is that the package only defines [`exports`](https://github.com/aduth/tannin/blob/630d3e3a00345005d1c06353779ce770ff22719f/packages/sprintf/package.json#L6-L11) and not `main`. `exports` has been supported in Node.js quite a ways back ([v12.x](https://nodejs.org/docs/latest/api/packages.html#exports)), but I'm not familiar enough with React...

@mdiarra3 Looks like some of the proofer refactoring was merged, can you take care of the rebase here? I'll plan to review what I can this morning.

How do I test this?

Nit: The title of the pull request doesn't seem accurate to its proposed changes, though the changelog itself looks correct.

> I was assuming that the artifacts from the `publish_er_diagram` job for the last successful `main` pipeline would be available at a well-known URL, something like https://docs.gitlab.com/ee/ci/jobs/job_artifacts.html#from-a-url. I now realize...

If someone fails authenticating or setting up with one authentication method and then switches to another, what do we expect the `mfa_attempts` to be for that second MFA method? I...

I think we could keep the logged value a single integer if we wanted, but in order to make sure that we're only logging attempts for that method, we'd need...

Is there a screenshot of what this is intended to look like?