Antoine du Hamel comments

Results 952 comments of


                                            Antoine du Hamel

AbortController.signal.addEventListener does not handle capture option

In Safari, like Firefox, the output is: ``` bar foo ``` It'd be interesting to pin down what the spec says about this. /cc @nodejs/web-standards

Trying to load two modules with the same URL throws an empty object

I think that's the documented behavior: https://github.com/nodejs/node/blob/ee5cfcb5f7797a48e144a72148d81b2474600f37/doc/api/module.md#L529-L532

Trying to load two modules with the same URL throws an empty object

> ```js > export const address = new URL(import.meta.url).pathname; > export const file = address.replace(/.*\//, ""); > > // register loader > if ( > !globalThis.window && > process.execArgv.some((flag) =>...

Trying to load two modules with the same URL throws an empty object

> i don't see the fragility there, is it about the regexp? Yes, file names can contain characters that have a special meaning in the context of a regex. It's...

Provide a way to get worker initialization error synchronously

You might be interested in https://www.npmjs.com/package/synchronous-worker > I tried to pass a timeout to `Atomics.wait()`, but It's just a random magic number because I don't know how long the worker...

deps: add deprecation warning for import assertion syntax

/cc @nodejs/v8

console: colorize console error and warn

There are some values which look quite broken with this change: - ` ./node -e 'console.warn(new Error);console.error(new Error)'` shows that that color stays until the first greyed line in the...

feature: allow usage of both `"exports"` and non-`"exports"` resolution

For reference, the exact section of the docs that mentions it is https://github.com/nodejs/node/blob/37ba7a36e9101861bf002f55e0cf36eb050d1b84/doc/api/packages.md#L557-L575 Regarding your second point: > * Add a config like `"resolveIfNotInExports"` so that e.g. `dist/compiled/regenerator-runtime` still resolves...

Re-flag `assert` syntax for import attributes in Node.js 22

> One year ago in #46830 there was a lot of support from TSC members to re-flag this syntax To be clear, https://github.com/nodejs/node/issues/46830 is about re-flagging the JSON modules implementation...

Re-flag `assert` syntax for import attributes in Node.js 22

Adding the https://github.com/nodejs/node/labels/release-agenda label as my position would depend on the decision of the LTS team regarding https://github.com/nodejs/node/issues/51622#issuecomment-1919789221.