Antoine du Hamel

We could still decide to change the default to be `upstream` rather than `remote-upstream` and/or improve the error message when the `git config` call fails to hint into what might...

We have a `toPathIfFileURL` internal API already, maybe we could expose it in the `node:url` module https://github.com/nodejs/node/blob/38b7961ce6ca906ac8bad4d32c347f7a724989f9/lib/internal/url.js#L1558-L1562 > For converting to URL: > > `url.from(URL | string)` I don't think...

> @aduh95 wdyt about an implementation that does that? ( [#41521 (comment)](https://github.com/nodejs/node/issues/41521#issuecomment-1042071145) ) I don't think we'll get consensus landing in core something that treats differently a string depending on...

I don't think we can be much more explicit than `url.toPathIfFileURL`.

> Node.js APIs do not seem to currently handle file URL strings Just to clarify, it does handle it but as a relative path (i.e. in your example it tries...

> This solution would particularly be useful for converting `import.meta.url` into a file path. You can already use [`fileURLToPath(import.meta.url)`](https://nodejs.org/dist/latest-v20.x/docs/api/url.html#urlfileurltopathurl) for that.

@deokjinkim please do not add https://github.com/nodejs/node/labels/request-ci label on PRs that already have a running CI, it adds up unnecessary load to the CI infrastructure, and won't make the PR land...

Well unless you're able to reproduce without using any external dependency, I'm going to assume one of your deps is importing a JSON module, which is still experimental hence the...

> Your first sentence also comes across as a bit condescending, but I'm just going to assume it's a language barrier situation and move on. Apologies, that was not my...

Not sure how I feel about promoting `NODE_DEBUG` usage in such warning, it's meant as a tool for Node.js core devs, not for end-users. Usually `--trace-warnings` gives back a useful...