Adrian Bonar

Wooooo!! —Adrian ________________________________ From: Devis Lucato ***@***.***> Sent: Tuesday, March 21, 2023 7:29:11 PM To: microsoft/semantic-kernel ***@***.***> Cc: Adrian Bonar (HE/HIM) ***@***.***>; Comment ***@***.***> Subject: Re: [microsoft/semantic-kernel] Sample 4: Using...

@craigomatic - when you're ready for this to come in, give it a formal approval.

FYI - we'll be bringing in this feature this week. I'll link to the PR when it get created before closing this PR.

https://github.com/microsoft/semantic-kernel/pull/801

> I'm not to happy with this `Config` class. The name should be more descriptive, like `ImportDocumentConfiguration`. > > Further, the `Config.GetConfig()` method should not hardcode where it gets the...

> How do we stop users from sending credentials over HTTP (not HTTPS) given that HTTPS is disabled in the sample? > > I'm concerned about the bad guidance we're...

> The original code written was without `this.` however StyleCop was enforcing the use of them so I assumed this was required. Happy to make any changes required as soon...

LGTM - please resolve conflicts and we'll bring it in.

🎉 From: Lee Miller ***@***.***> Sent: Friday, April 21, 2023 9:02 AM To: microsoft/semantic-kernel ***@***.***> Cc: Adrian Bonar (HE/HIM) ***@***.***>; Review requested ***@***.***> Subject: Re: [microsoft/semantic-kernel] Remove PlannerSkill and add...

@awharrison-28 could you take a look?