semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Sample 4 fit and finish (synchronous chat loading states, tool tips, sorted model dropdowns, dependency gates)

Open teresaqhoang opened this issue 2 years ago • 3 comments

Motivation and Context

  1. Enabling multiple loading states for synchronous chat
  2. Added informational tooltip about relevance
  3. Updated scroll check (scolls anytime response or chatHistory is updated)
  4. Sorted model options dropdown in Completion and Embeddings Model Setup
  5. Disable Embeddings config page if completion model hasn't been set (If completion hasn't been set, SK invoke will fail)

Description

image image

Models dropdown is split into 2 sections sorted alphabetically: "Suggested" and "Others", where Suggested is populated based on common naming conventions, where

  • Probable Embeddings Models contain "embedding" or "search"
  • All others are considered probable Completion Models image

Disclaimer updated image

Contribution Checklist

  • [X] The code builds clean without any errors or warnings
  • [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [X] All unit tests pass, and I have added new tests where possible
  • [X] I didn't break anyone :smile:

teresaqhoang avatar Mar 17 '23 19:03 teresaqhoang

LGTM

craigomatic avatar Mar 17 '23 19:03 craigomatic

@craigomatic - when you're ready for this to come in, give it a formal approval.

adrianwyatt avatar Mar 17 '23 20:03 adrianwyatt

I love the model suggestions!

awharrison-28 avatar Mar 17 '23 20:03 awharrison-28