semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Copilot Chat: Document Ingestion

Open TaoChenOSU opened this issue 1 year ago • 2 comments

Motivation and Context

To demonstrate the ability of the Copilot Chat App to ingest documents to memory and query against those documents.

Description

  1. Create DocumentSkill that can be invoked to ingest documents to memory and process queries coming from the chat.
  2. Create a simple console app called the document upload app to ingest documents to the app.

Contribution Checklist

  • [ ] The code builds clean without any errors or warnings
  • [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [ ] All unit tests pass, and I have added new tests where possible
  • [ ] I didn't break anyone :smile:

TaoChenOSU avatar Apr 19 '23 23:04 TaoChenOSU

Align casing for "DocumentUploadApp" with "webapp" and "webapi"

hathind-ms avatar Apr 20 '23 05:04 hathind-ms

I'm not to happy with this Config class. The name should be more descriptive, like ImportDocumentConfiguration.

Further, the Config.GetConfig() method should not hardcode where it gets the configuration from. It should use an IConfigurationSection instead.

The configuration should also be validated using Options Validation

MovGP0 avatar Apr 21 '23 13:04 MovGP0

I'm not to happy with this Config class. The name should be more descriptive, like ImportDocumentConfiguration.

Further, the Config.GetConfig() method should not hardcode where it gets the configuration from. It should use an IConfigurationSection instead.

The configuration should also be validated using Options Validation

We're in the midst of refactoring CopilotChat's configuration to follow the Options pattern. Stay tuned!

adrianwyatt avatar Apr 21 '23 18:04 adrianwyatt