semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

Sample 4: Using memory and embeddings with GitHub (#94)

Open shawncal opened this issue 2 years ago • 2 comments

Motivation and Context

This sample continues in the spirit of prior samples in the samples/apps folder with a goal of teaching developers how the concepts of memory and embeddings can be integrated.

Description

This sample includes a frontend app that allows the developer to enter the address of a publicly available Github repository, which is downloaded to the temp directory of the machine hosting the KernelHttpService sample application (can be the same machine).

image

Once downloaded the developer is able to have a conversation with the repository and see the impact of the relevance slider on the responses.

Contribution Checklist

  • [x] The code builds clean without any errors or warnings
  • [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
  • [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
  • [x] All unit tests pass, and I have added new tests where possible
  • [x] I didn't break anyone :smile:

shawncal avatar Mar 17 '23 16:03 shawncal

Getting a 400 on a local run: image image

Because after the save on Completion Mode, it's triggering the conditional that validates EmbeddingConfig
image However, the 400 seems to be related to something else, and even with --verbose logging, it's not apparent: image

thegovind avatar Mar 17 '23 23:03 thegovind

Getting a 400 on a local run...

Thank you for the feedback - I suspect this may have been due to the bug we fixed with long files

craigomatic avatar Mar 18 '23 00:03 craigomatic

AWESOME! 🎉

dluc avatar Mar 22 '23 02:03 dluc

Wooooo!!

—Adrian


From: Devis Lucato @.> Sent: Tuesday, March 21, 2023 7:29:11 PM To: microsoft/semantic-kernel @.> Cc: Adrian Bonar (HE/HIM) @.>; Comment @.> Subject: Re: [microsoft/semantic-kernel] Sample 4: Using memory and embeddings with GitHub (#94) (PR #96)

AWESOME! 🎉

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/semantic-kernel/pull/96#issuecomment-1478836624, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANONW5DJDKXL2PH6VGDEG23W5JPXPANCNFSM6AAAAAAV6X5A6Q. You are receiving this because you commented.Message ID: @.***>

adrianwyatt avatar Mar 22 '23 03:03 adrianwyatt