Alan Donovan

Results 347 comments of Alan Donovan

`types.Info` is, fundamentally, the set of type-checker annotations on the syntax tree. You can neither compute it nor meaningfully use it without syntax trees. Indeed, the keys of the types.Info.Scopes...

Possibly the right fix here is just: ```diff --- a/go/packages/packages.go +++ b/go/packages/packages.go @@ -1158,7 +1158,7 @@ func (ld *loader) loadPackage(lpkg *loaderPackage) { } lpkg.Syntax = files - if ld.Config.Mode&NeedTypes ==...

A Cmd object can be used for at most one process. See: ```go // A Cmd cannot be reused after calling its [Cmd.Start], [Cmd.Run], // [Cmd.Output], or [Cmd.CombinedOutput] methods. ```...

> > Therefore this is working as intended > > I don't think so because the error is returned by cmd.Wait not by cmd.Start. cmd.Start does not return an error....

> In my opinion, this rule should be related only if one of these methods didn't return an error. In my example, the first cmd.Start() returns an error. Also, this...

Since Start already does detect re-use (by returning an error) I don't think any changes are necessary, so I'm going to close this issue.

> > Since Start already does detect re-use (by returning an error)... > > Sorry but you are wrong. The second cmd.Start do not return an error. The error is...