Alan Donovan

cc @rsc, as author of this package.

It's easier to see the desired behavior when the difference in length is larger: https://go.dev/play/p/n0dnfZkATl3?v=goprev I'm sure there are unfortunate edge cases (like yours) where the behavior is a little...

@randall77 See the linked repo, which contains the patched code and the benchmark results. The diff is hard to see (it's not even in the history of the repo), but...

I use `M-x eglot-rename` in Emacs all the time and rarely notice that it fails because of compilation errors. This is very useful but it does make me nervous that...

> [Rob] I wish we could do this but the problem with inserting a prompt in the middle of a rename is that many clients will deadlock or timeout the...

This stack `dumPAQ` was [reported by telemetry](https://telemetry.go.dev/data/2025-12-04): - `crash/crash` - [`runtime.gopanic:+69,+0x14f`](https://cs.opensource.google/go/go/+/go1.25.3:src/runtime/panic.go;l=802) - [`go/types.(*Checker).handleBailout:+25,+0x9b`](https://cs.opensource.google/go/go/+/go1.25.3:src/go/types/check.go;l=467) - [`go/types.(*Checker).Files.deferwrap1:+0,+0x27`](https://cs.opensource.google/go/go/+/go1.25.3:src/go/types/check.go;l=484) - [`runtime.gopanic:+50,+0x11f`](https://cs.opensource.google/go/go/+/go1.25.3:src/runtime/panic.go;l=783) - `runtime.panicmem:=262,+0x2e7` - [`runtime.sigpanic:+19,+0x2b8`](https://cs.opensource.google/go/go/+/go1.25.3:src/runtime/signal_unix.go;l=925) - [`go/types.under:+4,+0x3c`](https://cs.opensource.google/go/go/+/go1.25.3:src/go/types/under.go;l=18) - `go/types.isBasic:=38,+0x23` - [`go/types.isString:+0,+0x4c`](https://cs.opensource.google/go/go/+/go1.25.3:src/go/types/predicates.go;l=30) - [`go/types.(*Checker).builtin.func2:+4,+0x93`](https://cs.opensource.google/go/go/+/go1.25.3:src/go/types/builtins.go;l=108) -...

This should be an easy fix along the lines of: ```diff --- a/src/cmd/go/internal/doc/pkg.go +++ b/src/cmd/go/internal/doc/pkg.go @@ -947,10 +947,11 @@ func trimUnexportedFields(fields *ast.FieldList, isInterface bool) *ast.FieldLis constraint := false switch ident...

cc: @h9jiang

Comment 6: (Sorry, didn't notice this till today.) To detect this situation in general, we need to find all assignments to non-address-taken local variables (except named return parameters) on which...

This stack `rnoW6w` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2024-05-23.json): ``` gopls/bug golang.org/x/tools/gopls/internal/util/bug.report:+35 golang.org/x/tools/gopls/internal/util/bug.Reportf:+1 golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics.func1:+50 golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics:+122 golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackage:+127 golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage:+70 golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func2:+1 golang.org/x/sync/errgroup.(*Group).Go.func1:+3 runtime.goexit:+0 ``` ``` golang.org/x/tools/[email protected] go1.22.2 windows/amd64 vscode (1) ``` Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.