Alan Donovan
Alan Donovan
This proposal seems reasonable to me. A few thoughts: Given that absolute line numbers in expectations are inherently fragile, it might be more robust to permit relative ones (e.g. +5)...
I applied the patch below to lostcancel. - VS Code correctly displays the related information (though the UI is a little clunky: clicking on the related link moves the cursor...
Fair enough. I support this proposal, amended relative line numbers and dropping the "end" position.
> Is there any kind of "official" approval (or rejection) I should be waiting for before working on this? I think this is a good idea, but there are definitely...
cc: @h9jiang
cc: @h9jiang. See golang/vscode-go#1594 for original feature issue.
Likely a dup of https://github.com/golang/go/issues/70172. The upcoming version of gopls (which you can try out using `go install golang.org/x/tools/[email protected]`) features a new implementation of the module index which should greatly...
Hmm. Thanks for checking.
Thanks, I can reproduce this readily from your instructions. It is indeed a runaway file system walk in the module indexing code, as witnessed by the attached traceback. [traceback.txt](https://github.com/user-attachments/files/21375740/traceback.txt) ```...
> There are definitely legitimate use cases for symlinks outside of the dir, and I don't know what else do other than follow them. Legitimate uses for a symbolic link...