Alan Donovan
Alan Donovan
Thanks Atreya, it looks like you're off to a good start. A few things I notice right off the bat: - When the tool is invoked with multiple initial packages,...
I'm sure you can appreciate the irony of a dependency elimination tool itself having unnecessary dependencies, so I would prefer not to import other packages solely for cosmetic reasons. I...
Good point, the client-side code does already have a dynamic dependency on jQuery from a CDN. I suppose adding a similar dependency for CSS would be fine, if the CSS...
Thanks; these both fit the bill. Take your pick.
> The refactoring tool should only affect structs that are currently being used for the interface. That is the intended current behavior of gorename: it uses the [satisfy](https://pkg.go.dev/golang.org/x/tools/refactor/satisfy) package to...
Yes, it could be. Could you try the same renaming from the command line and see if it works? That would tell us for sure. Thanks.
See also https://github.com/microsoft/language-server-protocol/issues/1466
I think 'free' was a relic from the Go implementation; it used a freelist to reduce the cost of memory allocation, which is (or at least, was then), higher in...
The type_parameter_list production seems not to be aware of constraints; it uses the same logic as ordinary parameters: https://github.com/tree-sitter/tree-sitter-go/blob/07d722831382a043b16547b6d9202f3da07f3cb3/grammar.js#L218-L222
The optionality should be removed here, but I think it might require additional handling to ensure that EOF inserts a final newline (terminator): https://github.com/tree-sitter/tree-sitter-go/blob/07d722831382a043b16547b6d9202f3da07f3cb3/grammar.js#L107 I suspect in practice it's less...