Alan Donovan

Google Brooklyn, NY Software engineer on Go team at Google. Ex-GitHubber, ex-xoogler; co-author of https://gopl.io.

Results 347 comments of


                                            Alan Donovan

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `lpgZrA` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-05-02.json): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.24.1:src/runtime/panic.go;l=811) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.24.1:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=398) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).call:+26`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=177) - [`golang.org/x/tools/refactor/satisfy.(*Finder).exprN:+9`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=130) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=532) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=105) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `P3nHGA` was [reported by telemetry](https://telemetry.go.dev/data/2025-06-08): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.24.3:src/runtime/panic.go;l=811) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.24.3:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=398) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).call:+26`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=177) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).valueSpec:+8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=248) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+11`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=508) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `CjT0cQ` was [reported by telemetry](https://telemetry.go.dev/data/2025-06-11): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.23.6:src/runtime/panic.go;l=804) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.23.6:src/runtime/signal_unix.go;l=917) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=398) - [`golang.org/x/tools/refactor/satisfy.(*Finder).call:+26`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=177) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=537) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+98`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=595) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `EHoAAA` was [reported by telemetry](https://telemetry.go.dev/data/2025-06-07): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.24.0:src/runtime/panic.go;l=806) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.24.0:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=398) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=537) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=105) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/golang/rename_check.go;l=882) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/golang/rename_check.go;l=791) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `c7_ouw` was [reported by telemetry](https://telemetry.go.dev/data/2025-06-16): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.24.1:src/runtime/panic.go;l=811) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.24.1:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=398) - [`golang.org/x/tools/refactor/satisfy.(*Finder).call:+26`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=177) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=461) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=537) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=587) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:refactor/satisfy/find.go;l=105) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/golang/rename_check.go;l=882) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `fV5TIg` was [reported by telemetry](https://telemetry.go.dev/data/2025-07-10): - `crash/crash` - [`runtime.gopanic:+69,+0x153`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/panic.go;l=811) - `runtime.panicmem:=262,+0x2ff` - [`runtime.sigpanic:+19,+0x2cc`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75,+0x1c8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=401) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+148,+0x613`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=474) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+97,+0x74b`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=597) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x87f`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+204,+0x64b`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=704) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x87f`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+204,+0x64b`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=704) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `XPbWtg` was [reported by telemetry](https://telemetry.go.dev/data/2025-07-15): - `crash/crash` - [`runtime.gopanic:+69,+0x153`](https://cs.opensource.google/go/go/+/go1.24.3:src/runtime/panic.go;l=811) - `runtime.panicmem:=262,+0x2ff` - [`runtime.sigpanic:+19,+0x2cc`](https://cs.opensource.google/go/go/+/go1.24.3:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75,+0x1c8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=401) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40,+0xe17`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=540) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x87f`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+100,+0x77b`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=600) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x87f`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+22,+0x213`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=108) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27,+0x2b3`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:gopls/internal/golang/rename_check.go;l=878) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `tITmvA` was [reported by telemetry](https://telemetry.go.dev/data/2025-07-20): - `crash/crash` - [`runtime.gopanic:+69,+0x167`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/panic.go;l=811) - `runtime.panicmem:=262,+0x358` - [`runtime.sigpanic:+19,+0x328`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75,+0x239`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=401) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138,+0xc10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=464) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+68,+0x98`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=568) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x985`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+22,+0x206`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=108) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27,+0x31c`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:gopls/internal/golang/rename_check.go;l=878) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178,+0x3e4`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:gopls/internal/golang/rename_check.go;l=787) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `HkEiLQ` was [reported by telemetry](https://telemetry.go.dev/data/2025-07-21): - `crash/crash` - [`runtime.gopanic:+69,+0x153`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/panic.go;l=811) - `runtime.panicmem:=262,+0x2ff` - [`runtime.sigpanic:+19,+0x2cc`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75,+0x1c8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=401) - [`golang.org/x/tools/refactor/satisfy.(*Finder).call:+26,+0x3fb`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=180) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138,+0xaa7`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=464) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40,+0xe17`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=540) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x87f`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) - [`golang.org/x/tools/refactor/satisfy.(*Finder).Find:+22,+0x213`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=108) - [`golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27,+0x2b3`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:gopls/internal/golang/rename_check.go;l=878) -...

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr

This stack `nBrZxA` was [reported by telemetry](https://telemetry.go.dev/data/2025-07-26): - `crash/crash` - [`runtime.gopanic:+69,+0x167`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/panic.go;l=811) - `runtime.panicmem:=262,+0x358` - [`runtime.sigpanic:+19,+0x328`](https://cs.opensource.google/go/go/+/go1.24.4:src/runtime/signal_unix.go;l=925) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+75,+0x239`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=401) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+138,+0xc10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=464) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+38,+0xe09`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=364) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+38,+0xe09`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=364) - [`golang.org/x/tools/refactor/satisfy.(*Finder).expr:+145,+0x104`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=471) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+40,+0x107e`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=540) - [`golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90,+0x985`](https://cs.opensource.google/go/x/tools/+/gopls/v0.19.1:refactor/satisfy/find.go;l=590) -...