Alan Donovan

Results 347 comments of Alan Donovan

I wonder whether restricting this to just variables that are (or contain) sync.Mutex or atomic.Counter or a handful of other types that invite concurrent mutation might deliver most of the...

> Or maybe just global variables that are written outside of `init` functions? That's a good metric too, so long as you include "address-taken" as a form of write.

A related [bug](https://github.com/golang/go/issues/68334) in go/types was fixed in go1.22.6, so it might be worth upgrading your Go toolchain and reinstalling gopls to see if this fixes the problem.

(Sorry for neglecting this.) Sorry for defining the conflicting symbols. We don't have a specific proposal to deprecate and delete cmd/gorename, but we probably should as its core functionality is...

Filed: - https://github.com/golang/go/issues/69360

> My first thought was that we shouldn't need to specify this at all, it should be assumed. But then again, is formatting specified to be implementation-defined in any way?...

Fair enough. Perhaps it's enough to say nothing; but the Java implementation should be fixed.

> do we want to specify exact formatting conversions or leave it implementation defined? Or to put it another way, is a compliant implementation obligated to reimplement the exact formatting...

Funny, https://github.com/ulfjack/ryu was written by the former TL of Bazel. We don't use it in Starlark, but we're aware that we should: https://github.com/bazelbuild/bazel/blob/5ac37924408db7dfc4e100e01f24b508a7e4b7a6/src/main/java/net/starlark/java/eval/StarlarkFloat.java#L151-L162 P.S. Hey Jeremy, very long time no...

Shouldn't it be a ["push" iterator](https://github.com/golang/go/issues/61405) of type `func (m *Mutex) Do(f func() bool)` so that you can express your critical section as a block? ``` for range mu.Do {...