Alan Donovan

See: - https://github.com/microsoft/language-server-protocol/issues/377 - https://github.com/microsoft/language-server-protocol/issues/1466 As soon as LSP supports a range in a hover request, we should add support for it to gopls.

> @adonovan should we follow the Rust team's lead and just ship first and ask questions later? :) I nudged the 377 issue last night and I think the dominoes...

This was about an _escaped_ newline _within a string literal_. There is no NEWLINE token, only a string. Unescaped: ``` xtools$ python3 -c $'print(ord("""\n"""))' 10 xtools$ python3 -c $'print(ord("""\r"""))' 10...

The Escaped examples were intended to demonstrate that the actual call was `print("")`, since print adds a newline. Perhaps a clearer demonstration would be: ``` python3 -c $'print(len("""\\\n"""))' 0 ```...

Gopls already supports a setting called [symbolScope](https://github.com/golang/tools/blob/master/gopls/doc/settings.md#symbolscope-enum) that allows you to control this. The value you want is `workspace`.

> [@adonovan](https://github.com/adonovan) I did set that, and it did not work. Could you show the relevant portion of your gopls settings, and of the gopls RPC and server logs?

> gopls and gopls(server) show absolutely nothing when pressing ctrl+t. Hmm... then this cannot be a gopls issue. Transferring to vscode-go issue tracker.

> Do you have any news on the relevant Inspector (or presumably Cursor) API? I threw together a quick sketch in https://go.dev/cl/710655. Feedback welcome!

``` x/tools$ go test -bench=DiagnoseChange/kubernetes -v -benchmem ./gopls/internal/test/integration/bench -gopls_cpuprofile=prof -kubernetes_dir=/tmp/k8 ``` I should note that I ran this on a mac, and macOS' implementation of setitimer is quite unreliable. I...

Very satisfying reductions in CPU! I agree that the file-level check is probably the point of diminishing return. I see a flurry of recent comments. I look forward to updating...