Alan Donovan

This stack `jAlTmg` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-03-03.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Reportf:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/util/bug/bug.go;l=54) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+78`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1111) - [`golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1363) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+6`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1139) - [`golang.org/x/tools/gopls/internal/analysis/nonewvars.run.func1:+29`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/analysis/nonewvars/nonewvars.go;l=70) - [`golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+20`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:go/ast/inspector/inspector.go;l=113) - [`golang.org/x/tools/gopls/internal/analysis/nonewvars.run:+7`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/analysis/nonewvars/nonewvars.go;l=41) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func7:+31`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1214) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec:+282`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1215) -...

This stack `Ube-fg` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-03-09.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Reportf:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/util/bug/bug.go;l=54) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+78`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/cache/analysis.go;l=1111) - [`golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/cache/analysis.go;l=1363) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+6`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/cache/analysis.go;l=1139) - [`golang.org/x/tools/gopls/internal/analysis/noresultvalues.run.func1:+25`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/analysis/noresultvalues/noresultvalues.go;l=65) - [`golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+20`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:go/ast/inspector/inspector.go;l=113) - [`golang.org/x/tools/gopls/internal/analysis/noresultvalues.run:+7`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/analysis/noresultvalues/noresultvalues.go;l=40) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func7:+31`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/cache/analysis.go;l=1214) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec:+282`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.0:gopls/internal/cache/analysis.go;l=1215) -...

Related to: - https://github.com/golang/go/issues/71659 - https://github.com/golang/go/issues/71812 CL https://go.dev/cl/666675 should have effectively mitigated this.

This stack `20eLzA` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-05-21.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Reportf:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/util/bug/bug.go;l=54) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+78`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1111) - [`golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1363) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+6`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1139) - [`golang.org/x/tools/gopls/internal/analysis/nonewvars.run.func1:+29`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/analysis/nonewvars/nonewvars.go;l=70) - [`golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+20`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:go/ast/inspector/inspector.go;l=113) - [`golang.org/x/tools/gopls/internal/analysis/nonewvars.run:+7`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/analysis/nonewvars/nonewvars.go;l=41) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec.func7:+31`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1214) - [`golang.org/x/tools/gopls/internal/cache.(*action).exec:+282`](https://cs.opensource.google/go/x/tools/+/gopls/v0.18.1:gopls/internal/cache/analysis.go;l=1215) -...

This feature is supported by gopls at master, so we could usefully add this to eglot now. Let me know if there's anything I can do to help.

> I'm not thrilled about looking at all file names in the directory. What's the objection? I too had an esthetic objection to the code when I first wrote it,...

Another version of the same recovery cascade: ``` package main import "fmt" func nop(...any){} func main() { nop(1, 2, 3 fmt.Println) // notice missing comma after 3 nop() nop() nop()...

Here's a variant distilled from https://github.com/golang/go/issues/68918 in which the parser swallowed (originally) thousands of lines during recovery: ``` package p func f() { h(a b, case c: if e.Len !=...

The failing assertion checks that each reference to the function or method of interest is a call to to a symbol with the same name and package as the original...

This stack `vmzEcA` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-27.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Errorf:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/util/bug/bug.go;l=61) - [`golang.org/x/tools/gopls/internal/golang.inlineAllCalls:+98`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/golang/inline_all.go;l=145) - [`golang.org/x/tools/gopls/internal/golang.rewriteCalls:+114`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/golang/change_signature.go;l=471) - [`golang.org/x/tools/gopls/internal/golang.RemoveUnusedParameter:+81`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/golang/change_signature.go;l=124) - [`golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature.func1:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/server/command.go;l=1338) - [`golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/server/command.go;l=174) - [`golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+73`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/server/command.go;l=201) - [`golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/server/command.go;l=1334) - [`golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+39`](https://cs.opensource.google/go/x/tools/+/gopls/v0.16.2:gopls/internal/protocol/command/command_gen.go;l=145) -...