go gopls/internal/analysis: noresultvalues diagnostic triggers "end

#!stacks
"bug.Reportf" && "cache.(*action).exec.func2:+78"

		if end > fileEnd+1 {
			if !fixed {
				bug.Reportf("end > end of file + 1")
			}
			end = fileEnd
		}

This stack lMZltw was reported by telemetry:

noresultvalues reports a diagnostic with an End position well beyond EOF:

			pass.Report(analysis.Diagnostic{
				Pos:     err.Pos,
				End:     analysisinternal.TypeErrorEndPos(pass.Fset, buf.Bytes(), err.Pos),
				Message: err.Msg,
				SuggestedFixes: []analysis.SuggestedFix{{
					Message: "Delete return values",
					TextEdits: []analysis.TextEdit{{
						Pos:     retStmt.Pos(),
						End:     retStmt.End(),
						NewText: []byte("return"),
					}},
				}},
			})

The file was not "fixed", i.e. it is unmodified parser output.

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+78
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run.func1:+25
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+11
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run:+7
golang.org/x/tools/gopls/internal/cache.(*action).exec.func7:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+277
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.22.4 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks. Dups: PFz3wQ

Jun 21 '24 14:06 adonovan

Similar Issues

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

Jun 21 '24 14:06 gabyhelp

This stack PFz3wQ was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.2 linux/amd64 other,vscode (1)
golang.org/x/tools/[email protected] go1.23.1 linux/amd64 vscode (1)

Oct 18 '24 16:10 adonovan

This stack uU3LXw was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 vscode (1)

Oct 31 '24 18:10 adonovan

This is probably a bit gnarly to track down, though surely it's a go/parser bug. Bumping to v0.18, when hopefully we can fix go/parser.

Nov 15 '24 20:11 findleyr

This stack s5dvOQ was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.3 windows/amd64 vscode (1)

Dec 12 '24 18:12 adonovan

This stack v7eTGw was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.4 windows/amd64 vscode (1)

Jan 06 '25 23:01 adonovan

This stack euXauA was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.6 darwin/arm64 vscode (1)

Feb 27 '25 16:02 adonovan

This stack jAlTmg was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1)

Mar 06 '25 17:03 adonovan

This stack Ube-fg was reported by telemetry:

golang.org/x/tools/[email protected] go1.24.0 linux/amd64 other,vscode (1)

Mar 10 '25 16:03 adonovan

Related to:

https://github.com/golang/go/issues/71659
https://github.com/golang/go/issues/71812

CL https://go.dev/cl/666675 should have effectively mitigated this.

Apr 23 '25 18:04 adonovan

This stack 20eLzA was reported by telemetry:

golang.org/x/tools/[email protected] go1.24.3 linux/amd64 vscode (1)

May 23 '25 20:05 adonovan

gopls/internal/analysis: noresultvalues diagnostic triggers "end > end of file + 1" bug (via telemetry)