Adam Scott

Results 211 comments of Adam Scott

Pushed to 4.2 milestone, as this is an enhancement PR and as we're in 4.1 feature freeze. Though, as it seems to be a good one, I added it to...

@vnen Is it ready to be merged in 4.1?

@vonagam Moved the milestone to 4.2, then. I added the PR to the list of PRs to review as a team in the next weeks. I'm taking a note to...

I wonder if macOS has another behavior when using home and end keys.

I installed a macOS virtual machine to test the issue (why-oh-why it doesn't pass the unit tests on macOS!?)

> > why-oh-why it doesn't pass the unit tests on macOS!? > > I suspect it's related to `SEND_GUI_ACTION("ui_end");`, this macro is sending a key combination for the action (`End`...

I just added the same functionality for `ui_text_caret_line_start` and `ui_text_caret_line_end` and ~~disabled the tests for `ui_home` and `ui_end` on macOS~~ removed `ui_home` and `ui_end`.

> Would this work, or would class `B` look straight to `BaseClass`? Gonna test this at once.

I updated the logic! It now checks for outer classes and their extended classes, without the need of adding one more loop. I prioritized the outer classes first, as this...