godot icon indicating copy to clipboard operation
godot copied to clipboard

Improvements to GDScript identifier tokenization

Open AThousandShips opened this issue 2 years ago • 1 comments

Makes potential_identifier() exit early if not ascii-only.

Edit: Was unsure if the token being created before pushing errors was important, so kept that order.

AThousandShips avatar Feb 13 '23 14:02 AThousandShips

Pushed to 4.2 milestone, as this is an enhancement PR and as we're in 4.1 feature freeze. Though, as it seems to be a good one, I added it to the list of PRs to team review to not forget it.

adamscott avatar Jun 17 '23 14:06 adamscott

Thanks!

YuriSizov avatar Jul 31 '23 19:07 YuriSizov

Thank you!

AThousandShips avatar Jul 31 '23 19:07 AThousandShips