Alexandre Conrad-Dormoy
Alexandre Conrad-Dormoy
I'd like to bump this thread again since I'm still seeing the issue with coverage v6. I posted about it in this other project https://github.com/aconrad/pycobertura/issues/133#issuecomment-1036466783 but I will copy-paste here...
Ah, we're getting conflicts now, naturally.
Can you update from master? I enabled Github Actions although we don't have the coverage pipeline working for now, will have to do that subsequently. See #139.
Hm, this `cobertura.xml` file was taken from the internet somewhere, I didn't generate it – I was looking for a sample cobertura file to use for testing when I started...
> I think for now it would be best to remove these lines (maybe you could open a separate PR so that we have this well tracked). I'll have to...
The method `Cobertura.files()` was designed to deduplicate filenames if they appeared multiple times and we should retain that behavior since that seems to be a valid use case (the motivation...
> but I am not sure I quite understood the above... My understanding is that if we have a file `foods.py`, this file could have `class Apple: ...` and `class...
Hm. Let me take a closer look at #132, I haven't looked into it yet.
> The only question one might ask is why are we parsing on `\\class` and not on something like `filename` or `file path`(because there could be 2 files with same...
This looks good, thanks! Can we update CHANGES file? Also, should we add a note somewhere in the README about this new option?