Alexandre Conrad-Dormoy
Alexandre Conrad-Dormoy
> How is this being handled? > The PR was closed, but I would be happy if you could respond! What @Halu89 mentioned is the way to go. The response...
This approach is actually a best practice in TypeScript. When calling `api.getPetById({ petId: 1 })` (from @Halu89's example), TypeScript can't know in advance what kind of error might be thrown....
I see your point. So there is a preference in always returning the response object if there is one, instead of throwing regardless of the status code. As for the...
As for the original topic from @AlexandreFinne, the suggestion is to return the error message from the response error. The suggestion assumes that 1) the error response is JSON content...
Tagging @Eliran-Turgeman and @Saarett who were involved in authoring/reviewing the original code in https://github.com/bridgecrewio/checkov/pull/2789.
@Saarett Thanks! A check was failing because of an incorrect title, which I updated (hopefully it's good now)
> If you are looking for `viewer-only`, check this https://www.npmjs.com/package/react-json-tree I'll take a look, thanks. But is it as pretty as this one though? :)
The lib `react-json-tree` is slightly larger according to bundlephobia. https://bundlephobia.com/package/[email protected] https://bundlephobia.com/package/[email protected] But I suppose the real test should be looking at the size of the lib after tree-shaking.
I think it's okay to leave it as is. I might fork the repo when I get a chance and experiment by ripping out the editing features and see how...
@goatwu1993 can you help answer? I'm not familiar with GitHub annotations.