Ava Chow
Ava Chow
Silent merge conflict with master
ACK fa3f15f2dd94ae597a66037f5928fe4e90fe099d
I don't think the current location in initialization is correct. ~50 lines above, we start the thread for importing blocks from an external file. This thread will be copying the...
> Wouldn't be better to replace [09a0dcb](https://github.com/bitcoin/bitcoin/commit/09a0dcb8ce1607e902e16a1671b91e33c0ee5172) for [furszy/bitcoin@0fe6524](https://github.com/furszy/bitcoin/commit/0fe65242b4f0794650c4fdafff4686e8bc316fbd)? > ... > Which saves us from doing the double `CalculateMaximumSignedInputSize` calculation that [09a0dcb](https://github.com/bitcoin/bitcoin/commit/09a0dcb8ce1607e902e16a1671b91e33c0ee5172) is introducing. This was the original approach,...
@furszy Implemented as suggested.
Rebased for a silent merge conflict in the test.
> Why doesn't this extend `upgradewallet`? It didn't feel like it fit `upgradewallet` as I see that more for changing the wallet version number and using legacy wallet features. But...
> I think we should only add this functionality after `sqlite` wallets? Otherwise you'd keep migrating. I think there's a question of whether we want to keep sqlite separate from...
> Do you know what the performance of a wallet would be like, in the case of a non-HD wallet being migrated? Probably worse.
> but I prefer this to be in the wallet tool. I would prefer this to be accessible to most users so that more people can move to using descriptor...