Ava Chow
Ava Chow
re-ACK b16f93caddcd3254eaf3dc43e09adf2142a9c40a
> If someone really doesn't want this behaviour, wouldn't they probably just not have a legacy/internal provider? It is not possible to remove a provider. A user would have to...
> For privacy reasons I might want to have P2PKH change if sending to P2PKH recipient. You can still choose to by setting the startup option `-changetype`, or explicitly setting...
Rebased for silent merge conflict.
> Why not? If the user is sending bitcoin to legacy address it should be okay to use a legacy change address by default. Not necessarily. The user is sending...
Since this was introduced in 23.0, there has not been a noticeable increase in legacy outputs being created, so there doesn't seem to be much of an effect either way....
It shouldn't be necessary to pass an entire CMutableTransaction to SelectCoins. CoinSelectionParams already has the information about the sizes of the rest of the transaction, modulo the change output. So...
The size is always vsize, so multiplyging by WITNESS_SCALE_FACTOR is sufficient to convert to weight. There will be some rounding error, but vsize always rounds up, so weight calculated in...
ACK 0cb6d2aec63aec76a517b8da621a3c53ab432632
ACK 90a5dfa5098f142ba8b7b2f20eac31f4095ca583