Andrew Bayer
Andrew Bayer
> This looks really good other than the one bug I mentioned! Just want to double check that this still fixes the race condition after your changes? As far as...
ping @pritidesai - I'd really like to get this merged. =)
> > Change PipelineRun timeout behavior for child TaskRuns and Runs to behave like cancellation rather than explicitly setting timeouts on the child tasks at runtime. > > Hi @abayer,...
> What I mean or rather my concern is - is there any change in the state transition which might impact existing use case. Aaaah - then no. The state...
I'm honestly open to either using `TaskRunCancelled` as we are now, or my original approach of a new timeout-specific spec status, but I do think that `TaskRunCancelled` is more accurate....
/retest
/approve /retest