WIP: Full set of changes for moving Resolution into Pipeline

[abayer]

Changes

DO NOT MERGE. This is my branch of changes for #4710 on top of #5200, broken up into separate commits which will each become a separate PR. I just wanted to get this up as a WIP PR to verify everything passes CI, and give reviewers an opportunity to look at the full picture of what the end result will look like and/or take a glance at individual commits before they are sequentially turned into PRs.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [ ] Has Docs included if any changes are user facing
• [ ] Has Tests included if any functionality added or changed
• [ ] Follows the commit message standard
• [ ] Meets the Tekton contributor standards (including functionality, content, code)
• [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

@abayer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from abayer after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%
test/controller.go	25.3%	24.2%	-1.0

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%
test/controller.go	25.3%	24.2%	-1.0

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%
test/controller.go	25.3%	24.2%	-1.0

[abayer]

/retest

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%
test/controller.go	25.3%	24.2%	-1.0

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
docs/resolver-template/cmd/demoresolver/main.go	Do not exist	72.7%
pkg/apis/config/feature_flags.go	81.8%	79.7%	-2.2
pkg/apis/resolution/v1alpha1/register.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_defaults.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_lifecycle.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_types.go	Do not exist	0.0%
pkg/apis/resolution/v1alpha1/resolution_request_validation.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	98.8%	97.8%	-1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	85.7%	89.2%	3.5
pkg/reconciler/resolutionrequest/controller.go	Do not exist	100.0%
pkg/reconciler/resolutionrequest/resolutionrequest.go	Do not exist	80.0%
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.3%	0.0
pkg/reconciler/taskrun/resources/taskref.go	83.0%	85.2%	2.2
pkg/resolution/common/context.go	Do not exist	100.0%
pkg/resolution/common/errors.go	Do not exist	18.8%
pkg/resolution/resolver/bundle/bundle.go	Do not exist	0.0%
pkg/resolution/resolver/bundle/params.go	Do not exist	75.9%
pkg/resolution/resolver/bundle/resolver.go	Do not exist	50.0%
pkg/resolution/resolver/framework/configstore.go	Do not exist	26.1%
pkg/resolution/resolver/framework/controller.go	Do not exist	55.4%
pkg/resolution/resolver/framework/fakeresolver.go	Do not exist	90.0%
pkg/resolution/resolver/framework/reconciler.go	Do not exist	72.7%
pkg/resolution/resolver/git/resolver.go	Do not exist	88.9%
pkg/resolution/resolver/hub/resolver.go	Do not exist	70.6%
test/controller.go	25.3%	24.2%	-1.0

[tekton-robot]

@abayer: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.