Aaron Miller

Results 114 comments of Aaron Miller

The alternative would be to mark the requirement like `gtsam ; python_version < '3.10'` in setup.py, which piptools understands correctly: ```diff diff --git a/dev_requirements.txt b/dev_requirements.txt index ae5b80a0a9d..c61f046c924 100644 --- a/dev_requirements.txt...

Yeah I don't particularly think we need to do this now

Cool, yeah I think the next steps here would be to add the `FUNCTION.ts.jinja` and probably `util.jinja`, and plug into `symforce_codegen_test` to have it generate most functions we currently generate...

This actually seems to break the markdown handling in the generated docs? Curious what environment you were seeing the broken link in ![image](https://user-images.githubusercontent.com/78561124/185999261-79a447bc-d8b5-4726-b955-e57ae276d7bb.png)

Huh, yep that's definitely wrong. We might have to play around a bit to find something that works both on github and other notebook renderers and in the docs? @bradley-solliday-skydio...

I'm a little confused what changed here such that we're seeing this now. I'd also strongly lean towards upgrading the pinned version of pip in our `dev_requirements.txt` if we in...

I think we'll need to remove the `format_matrix_subscript_accessor` change from here since it's a duplicate with #190 which makes the other required changes with `matrix_is_1d` and have this PR just...

Agree I think 1 should be fixed by #189 , and the other two should probably be their own issues 2) Hunch is that this is a "macOS `sed` doesn't...

I don't think the `ply` thing is a symforce issue - if we decide it is because someone hits it again we'll make a separate issue

I think it seems reasonable to put the generated python factors into `symforce-sym`, since we'll presumably do the same for C++ generated factor headers. Rerunning `pip install -e .` to...