symforce icon indicating copy to clipboard operation
symforce copied to clipboard

Concepts link was not including end parenthesis

Open kristen-skydio opened this issue 3 years ago • 3 comments

Small change to use encoded character which appears to work. Sorry for the nit. It was misdirecting me to https://en.wikipedia.org/wiki/Concept_(generic_programming

kristen-skydio avatar Aug 19 '22 19:08 kristen-skydio

This actually seems to break the markdown handling in the generated docs? Curious what environment you were seeing the broken link in image

aaron-skydio avatar Aug 22 '22 19:08 aaron-skydio

I'm seeing it within github

There's a hanging closing parenthesis: broken_link

And if you see the address of the link, it's missing it's closing parenthesis broken_link_2

kristen-skydio avatar Aug 22 '22 23:08 kristen-skydio

Huh, yep that's definitely wrong. We might have to play around a bit to find something that works both on github and other notebook renderers and in the docs? @bradley-solliday-skydio wanna take a look at this?

aaron-skydio avatar Aug 23 '22 00:08 aaron-skydio

I think github must have fixed their markdown renderer so this is no longer necessary - this looks right to me now in both the symforce docs and github on main

aaron-skydio avatar Feb 08 '23 19:02 aaron-skydio