Lukas Heumos

Results 522 comments of Lukas Heumos

This runs just fine in our CI. Maybe it was having a particularly bad day. Nevertheless, we can add some code to retry this if it fails. This is not...

Please feel free to merge it then when you think it's ready. I like the figure very much.

I could see it become a part of `ehrdata` and `ehrapy` depend on `ehrdata`. WDYT?

> @Zethson what is your stance on importing private variables from scanpy, as we are doing [elsewhere](https://github.com/theislab/ehrapy/blob/423a633c35efdd5be9992cade33443432274006f/ehrapy/plot/_scanpy_pl_api.py#L36) too? > > I remember in the past you've [added a fix](https://github.com/theislab/ehrapy/commit/f71f08e9b6ed924a600d88898de9abf6fa3ca301) of...

I see where you come from but I think we already have a ton of chapters. I have to think about it but intuitively I don't think it's the best...

@MaximilianNuber I can see that it's a draft PR and there's still a lot to do but please ensure that you adhere to our existing conventions such as Google docstrings,...

Oh, and just FYI: The pre-release CI is allowed to fail at the moment but the ReadTheDocs job is not. It must pass and the docs must look good.

@MaximilianNuber please feel free to ask me if you're stuck with something. I'm happy to guide a bit if I can. This is just a friendly and supportive check in...

Ahh no worries. Please take your time and don't stress yourself. No need for that. > I still need to look more into how GitHub Actions, CI, and sphinx work,...

Strategy 2 is more or less what we've been doing now because in almost all cases we densify. Speaking from experience, we are leaving a loooot of performance behind if...