ehrapy icon indicating copy to clipboard operation
ehrapy copied to clipboard

Make download part of ehrdata

Open eroell opened this issue 1 year ago • 2 comments

Description of feature

The _dataloader module is currently private. Should we make it be part of the public API? It is useful for downloading datasets, and could also be so for other developers.

The least reduces redundancy for us, without us using private modules across repos

https://github.com/theislab/ehrapy/blob/0a74f705650e71485de44d5054cd7145e27c4d62/ehrapy/data/_dataloader.py#L17

eroell avatar Nov 06 '24 11:11 eroell

I could see it become a part of ehrdata and ehrapy depend on ehrdata. WDYT?

Zethson avatar Nov 06 '24 11:11 Zethson

Sounds good to me :+1:

eroell avatar Nov 06 '24 11:11 eroell

Completed with https://github.com/theislab/ehrdata/pull/136.

The current use of ehrapy's download function in its datasets will be removed as per in ehrapy's dataset deprecationwarnings

eroell avatar Sep 21 '25 10:09 eroell