Matt
Matt
> I think that's fair potentially. I am unsure whether or not the compiler is actually spitting out significantly worse code due to the abstraction, the functions are marked final...
I don't think that we came to a conclusion on that discussion.
> @ZehMatt Shouldn’t the following variables be in here as well? > > gEntityLists _freeIdList _entityFlashingList gEntitySpatialIndex No, they are not saved in the file and are typically rebuilt upon...
> > > @ZehMatt Shouldn’t the following variables be in here as well? > > > gEntityLists _freeIdList _entityFlashingList gEntitySpatialIndex > > > > > > No, they are not...
> Hm, _maybe_. There is a similarly needed structure called `GameState` which contains some park-related stuff and the date, which I would assume needs to be absorbed into GameState_t. But...
> I also don't know why Windows and such is failing on here as it builds just fine on my actual windows machine. It says it has replay faults? Run...
Please don't close PRs and open new ones, you can always overwrite the entire git history of your branch, for now its fine but in the future try to avoid...
What's the status on this PR?
> Realsteel ran into trouble with rebasing/merging/updating, and had some stuff in the changes list that shouldn’t have been there. I offered to rebase his branch (an offer he gladly...
I'm against changing the names, there are probably a lot of things that reference it by their current name and changing that will cause just confusion.