OpenRCT2 icon indicating copy to clipboard operation
OpenRCT2 copied to clipboard

Adding the new Steel Spinning Roller Coaster Track

Open Realsteel89 opened this issue 1 year ago • 36 comments

Adding the new Coaster Track Maurer/Gerstlauer Spinner grafik The Track is Based on the Maurer Spinning Coaster in Real Life and based as the MiniRollerCoaster from RCT2

What I did:

  • Building the new Track Model and render most of the sprites there are possible to the Coaster Track

  • limited it with the cheat function that only the track parts are possible without cheats that the real coaster has too

  • changing Supports from fork to tubes

  • changing some hights from supports to look nicer

  • adding vertical lift animation sprites to the coaster too (manually edding) grafik

  • adding an preview Image to coaster Type

  • changing the rendering sprites from small vertical loops because had some cutes by the border of the tiles so i edding it manually to look correct

Mistakes that i need to fix now:

  • Fixing the small loop sprites and bounding boxes (they currently glitch badly, although removing the small loops entirely is also an option)
  • fix maybe some hights of support

this track type can be so useful for more Coaster Types like Gerstlauer Eurofighter grafik Gerstlauer Spinner grafik Vekoma Family Coaster grafik

and so many one more....

It has 1274 Sprites so most of the Elements that the game can do at the moment limited by cheat setting on/off

later plans: -maybe realistic spinning maurer car for the track

  • vertical tower lift and an 110° Drop sprite grafik
  • maybe build animated breaks like the Minicoaster has with open/close animation

Important: The Problem that it exist actually no Car for the Track, you need to choose it via cheat funktion!

I would appreciate if someone could test to ensure that the branch is functional and I didn't forget to commit any sprites.

Realsteel89 avatar Jul 09 '23 13:07 Realsteel89

Please don't close PRs and open new ones, you can always overwrite the entire git history of your branch, for now its fine but in the future try to avoid that.

ZehMatt avatar Jul 09 '23 13:07 ZehMatt

klick the link scroll down a bit there you can find the latest artifact test version https://github.com/OpenRCT2/OpenRCT2/actions/runs/5502413365?pr=20587 grafik

Give me feedback please

Realsteel89 avatar Jul 10 '23 13:07 Realsteel89

Now I changed the Name to Maurer/Gerstlauer Spinning Roller Coaster.

I changed all Sprites, Folders, Strings, .ccp and .h files to the new name that fits better

change some Valiues of the Coaster to fit better to Maurer Spinner

PS: the close was an accident sorry

Realsteel89 avatar Jul 12 '23 15:07 Realsteel89

since i'm not that deep in git i had to do a hard reset to change the comit and then rebuild everything but it seems to work now. I have adjusted the names to most of the data so that it fits with the mapping. Only are the variables that I would still have to revise

and apologies in advance for the confusion

Realsteel89 avatar Jul 12 '23 22:07 Realsteel89

holy fuck what i did i think i changed the branch name but i deleted it oO So it's reopen again Shame to me sorry I am not so good in working with git😘

Realsteel89 avatar Jul 27 '23 11:07 Realsteel89

so now i am change some sprites, rework the animation chain of vertical peaces to look nicer, fix supports. I think i am done with it. its ready for view and checking

Realsteel89 avatar Aug 16 '23 00:08 Realsteel89

I will rework the backface and the chain parts of the track to look nicer so i need a little work to fix it all so please no merge yet

Realsteel89 avatar Sep 24 '23 10:09 Realsteel89

I will rework the backface and the chain parts of the track to look nicer so i need a little work to fix it all so please no merge yet

When you don't want something merged yet you should mark it as a draft until it is :)

karst avatar Sep 24 '23 11:09 karst

What's the status on this PR?

ZehMatt avatar Nov 05 '23 17:11 ZehMatt

Realsteel ran into trouble with rebasing/merging/updating, and had some stuff in the changes list that shouldn’t have been there. I offered to rebase his branch (an offer he gladly took).

I don’t know if it is fully finished yet, I imagine he’ll have to go through the line notes in any case (either addressing them or marking them as solved).

Gymnasiast avatar Nov 05 '23 17:11 Gymnasiast

Realsteel ran into trouble with rebasing/merging/updating, and had some stuff in the changes list that shouldn’t have been there. I offered to rebase his branch (an offer he gladly took).

Yeah I noticed that, appreciated.

I don’t know if it is fully finished yet, I imagine he’ll have to go through the line notes in any case (either addressing them or marking them as solved).

Fair enough, just wondering since it's still in draft and the activity stopped.

ZehMatt avatar Nov 05 '23 17:11 ZehMatt

The draft comes because we renewed all sprites to fit perfect to other tracks like giga, mini, Co. I add now the diagonal brakes and after your big changes into the code I try to rebase it and do something completely wrong. So now gymasiast fix my branch and I can go on it to finish this for merging. Think I need to check some supports that are not really correct but most of the stuff is done and work.

I will finish this these days to release it and open it for merging.

Realsteel89 avatar Nov 05 '23 19:11 Realsteel89

grafik changing booster and powert lifts to an wheel looking one because fits better to the track than the lsm one

Realsteel89 avatar Dec 09 '23 12:12 Realsteel89

The track looks very nice. I will give this a spin, pun intended, later today.

karst avatar Dec 16 '23 13:12 karst

I also need to give my appreciation for the seamless connection to the mini/giga image

karst avatar Dec 20 '23 01:12 karst

thanks for testing i will look today after work on this again and try to fix it

Realsteel89 avatar Dec 20 '23 06:12 Realsteel89

fixed this bounding box problem now grafik

Realsteel89 avatar Dec 21 '23 15:12 Realsteel89

grafik take some crazy layout to it

Realsteel89 avatar Dec 23 '23 11:12 Realsteel89

The smallest 1 tile curve I will add later after the ui stretch out from gymnasiast was merged.

Realsteel89 avatar Dec 27 '23 18:12 Realsteel89

Adding the 1 Tile Curve to the track peaces because very usefull only the thing you need grafik

to build it is before the ui changes come a bit stupid see in the video. https://gyazo.com/8ed48873bba5ddb9335dca6c42e216f0 add Supports like the steel wild mouse had

Realsteel89 avatar Jan 05 '24 19:01 Realsteel89

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

github-actions[bot] avatar Mar 04 '24 01:03 github-actions[bot]

that auto closing thing is sad :D

Realsteel89 avatar Mar 05 '24 08:03 Realsteel89

image

Regular turns are not available for selection without cheats atm.

image Supports aren't quite there yet, especially for steep pieces perhaps you can steal some code from the mini?

The supports are hiding behind track instead of being connected to them The small flat to steep piece doesn't connect at all.

image I don't think this looks very nice, I think they should be placed differently.

image The supports here don't look so nice yet either, especially the one on the bottom right and the middle one.

image

This support has a hole in it.

image One of these supports is floating and not supporting the track.

image The loops aren't done yet.

Please work a bit more on the supports.

You can use Spacek's TrackZoo to check out all supports.

karst avatar Mar 08 '24 23:03 karst

image

Regular turns are not available for selection without cheats atm.

image Supports aren't quite there yet, especially for steep pieces perhaps you can steal some code from the mini?

The supports are hiding behind track instead of being connected to them The small flat to steep piece doesn't connect at all.

image I don't think this looks very nice, I think they should be placed differently.

image The supports here don't look so nice yet either, especially the one on the bottom right and the middle one.

image

This support has a hole in it.

image One of these supports is floating and not supporting the track.

image The loops aren't done yet.

Please work a bit more on the supports.

You can use Spacek's TrackZoo to check out all supports.

Thanks for the review. I took another look at the code and realized that the same problems occur on vanilla tracks. Thanks to the perspective, since my track runs on z =9 which is relatively high, it just seems more extreme. Supports glitch in the same places on vanilla tracks as on my track. this seems to be a general codeerror in the support code not on the track itself. with the half loops i would have to increase the supports 2 units then they glitch like on all other vanilla tracks but are closer to the track. grafik grafik

grafik

the 1 tile curve has the same problems as the wild mouse steel roller coaster they also look like shit in vanilla.

grafik

the bug with the track i have to see if i ban it from the normal mode and only make it unlockable by cheat if that works or if it's because the logic of the game can't handle 4 different tracks totz that we have already extended the ui.

Realsteel89 avatar Mar 09 '24 02:03 Realsteel89

that pr is now ready to check some supports can't go better because the limits of the tile. That track has no car jet because we need an new animation mod for it but we can add it later than

Realsteel89 avatar Mar 10 '24 11:03 Realsteel89

because the ui bug was fixed i updated the branch to the newest version of develop

Realsteel89 avatar Mar 12 '24 01:03 Realsteel89

Rebased the branch again to account for recent changes (introduction of Classic Stand-Up, changes to sprites.json and the segment refactor).

Gymnasiast avatar Mar 30 '24 19:03 Gymnasiast

Thanks my friend I think this branch is ready for testing and than merging

Realsteel89 avatar Mar 30 '24 20:03 Realsteel89

Updated to actually version

Realsteel89 avatar Jul 28 '24 17:07 Realsteel89