Matt
Matt
I'm still not 100% convinced that this is a good change, the paths are clearly disconnected and its quite odd that guests still walk over it, I tested this with...
> @ZehMatt You want to preserve vanilla behavior and maintain backwards compatibility, yet also want to remove a feature (if only accessible through hack) that exists in vanilla? The guests...
> I'd rather see the getters throw when `ride` is null, instead of returning a magic number. This can be done later in another PR, just please create an issue...
> > I think the error handling should be changed in this PR already, that's quite the different behavior. > > It's not different from the current behaviour. The existing...
@AT41 are you planning to continue this PR?
> There's a CI/CD error that's failing after I implemented the extra enum for formatting, but unless there's a specific reason for those enum values to be set to those...
There is something to consider, some checks are just guarding against malicious inputs which can come from the network and some checks are for the user doing things that has...
Hm yeah, definitely makes sense for plugins, that slipped my mind.
I don't think passing the function name adds any benefit, we know what game action is called and this is just too verbose.
We can probably just omit displaying the info when its a no money scenario, not necessarily a bug, it just always keeps track of this.