OpenRCT2 Move map base z to constant

Move map base z to constant

Open Harry-Hopkinson opened this issue 1 year ago • 3 comments

Move the MapBaseZ gamestate variable to a constant as it's value never gets changed. For https://github.com/OpenRCT2/OpenRCT2/issues/21379

Feb 14 '24 18:02 Harry-Hopkinson

I don't think that we came to a conclusion on that discussion.

Feb 14 '24 18:02 ZehMatt

Sorry, I seemed to have jumped the gun. Should I close this PR or leave it open in case that they want to move the variable to a constant?

Feb 14 '24 19:02 Harry-Hopkinson

Let’s leave this open for a bit.

Feb 15 '24 12:02 Gymnasiast

We left the discussion open for a bit longer, and since no objections came forward, I think we can proceed with this.

Could you rename the MAPBASEZ constant to kMapBaseZ?

Feb 19 '24 10:02 Gymnasiast

I have renamed it to kMapBaseZ.

Feb 19 '24 11:02 Harry-Hopkinson

Fixed now, not sure how I missed that...

Feb 20 '24 10:02 Harry-Hopkinson