ZacSharp

Results 392 comments of ZacSharp

Yes, that method is likely part of the problem. However you should note that the usual player size is used in a lot more places so e.g. pathfinding will always...

Baritone should (maybe?) work on pigs. The problem with horses is that they make you effectively 2x3x2 blocks big and literally all movements are hardcoded for a 1x2x1 sized player.

If you want to use new types for setting values and be able to set them via commands / settings file you also have to implement a parser + serializer...

No, there is no style guide. For #4452 I went for the enum names mainly for ease of parsing, but generally I think using the textual id is preferable from...

Removing a public method from the API package. I'd say an `@Deprecated` is more appropriate. Otherwise a simple and sane looking change.

There is the possibility of `BaritoneAPI.getProvider().getAllBaritones().stream().map(Baritone::getPlayerContext).filter(c -> c.player() == entity).findFirst().get().getEyeHeight(true)`, but that's clearly worse and (re?)introducing `BaritoneProvider::getBaritoneForPlayer` wouldn't help much. Also why assume the entity is a player? I'd say...

Rebased onto 1.19.4: https://github.com/cabaletta/baritone/pull/4713

[:shrug:](https://github.com/cabaletta/baritone/commit/05ba817052cecdd605f04e8a27b24b9f12545a50) It doesn't actually store mp4s though. It uses a custom file format and for some reason uses the mp4 file extension.

Baritone doesn't even know which block will be the next to be placed until it actually places the block so skipping "the next 50 blocks to be placed" in the...

You might have some luck with `buildOnlySelection`, though I have to admit selecting parts to exclude rather than include would fit your case better. And if you select a cave...