Greg Korba
Greg Korba
Sorry @staabm for not picking this, but decision around such stuff is up to @keradus so I did not want to engage without being decisive. Tokenizer-related stuff in Fixer is...
FYI: Initial refactor of progress output handling is in #6848, when it gets merged I will rebase #6842 which brings new progress output formats (with file names).
Because of [reasoning provided in #5115](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/5115#issuecomment-2082310965), and also because it's not a widespread coding standard, I am going to close this, as I believe supporting this in the core of...
@mvorisek Are you telling me I wasted my time for implementing this 😩? Eeehhhh....
@kubawerlos do you have an idea why [this fails](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/9305289118/job/25611872183?pr=7705)? It imports and shortens `CoversClass` like [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/9305289118/job/25611872183?pr=7705#step:5:583), but at the same time leaves FQCN like [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/9305289118/job/25611872183?pr=7705#step:5:603) 😕. I need to go...
@mvorisek I've added this rule explicitly to the "highest" config, but it sometimes works and sometimes not 🤔.
@kubawerlos it works differently when you apply the "highest" ruleset to a single file or to the whole codebase. The CI outcome can be reproduced locally by running the exact...
It was magically* fixed since last rebase, so it's a good moment to review it and finally provide the fix for importing symbols 😁 . \* or it was fixed...
@keradus personally I think we rather should think about dropping 7.4 support and then we just could use union type in the signature, keeping one method for finding single/multiple kinds....
@u01jmg3 no, it still matches phpDoc's content so unused imports can be kept when they should be removed.