Greg Korba
Greg Korba
> For breaking PHP syntax (such as match, visible in one failed case) 👎🏼 That's obvious 🙂. These fails are here because I did not run whole test class locally,...
Why new PR instead of moving the config from the ruleset to dist config in #7786?
I would like to see #7971 to be merged first so we can continue with further works with bumped PHPStan level. I am also not a fan of separate PR,...
This is actually great idea and I am surprised we did not think about it during the code review 🤔. In our case it's also required to keep annotations as...
Personally I would expect providing this exact changes in #7786, then creating new PR/discussion for aligning about `@PhpCsFixer` ruleset, that's why I asked why this particular PR was created. But...
@mvorisek I think @keradus' [comment](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7965#issuecomment-2094073161) was not addressed. @nicolas-grekas is this something you would like to have in the Symfony ruleset?
@mvorisek I agree we can add it to our rule set and move it to Symfony in the future if needed. But there are some failures in the CI to...
@mvorisek will be fixed in #8073.
Thanks @mvorisek 🍻!
Similar to #3168 and #1217 - it's not that easy to mark the line when multiline should be enforced. Items count is not enough IMHO, because you rather wouldn't want...