Greg Korba

Results 540 comments of Greg Korba

No, I find inheritance information helpful, but only if implemented the way I described. It can help to find out why the fixer is enabled and _how_ the rule is...

@Aerendir sorry for the delay, I did not have enough time recently to look at this. In terms of getting information about the source of the rule in the resolved...

~FYI: PHPStorm reports duplicated code fragment:~ Fixed

@ntzm do you have an idea why nested `if` test case fails? I did not have time to dig it yet, maybe you can help make pipeline green?

@SpacePossum please look [here](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7061#discussion_r1254982555) 😉. I've rebased it only without any additional changes, will try to solve CI issues soon but I don't want to work on this PR more...

Personally I consider something as draft when it is not finished in terms of conception, so potential reviewers would know there might be any changes provided. This is ~final state...

No, it means that there's no much point in reviewing draft, unless author explicitly asks for the feedback (personally I ignore draft MRs, more [here](https://blog.codito.dev/2022/07/code-review-good-practices/#draft-wip)). That's why I use draft...

@SpacePossum which question of yours I did not respond to 🤷‍♂️? In terms of empty `{}` I just redirected you to other thread where I already said I don't want...

It is not finished in terms of CI status. It may look unfinished in terms of feature coverage and feel free to leave any comment related to current code. I'll...

I really need to get back to this and try to finish it 😅. Sorry folks for the long delay!