Greg Korba

Results 540 comments of Greg Korba

Just for the record: in #7053 we added ability to place namespace declaration in the same line as `

@voxlz you need to use `VersionSpecificCodeSample` in that case.

Something weird happened here 😅. @voxlz was it intentional?

@voxlz no, it wasn't forgotten, but there are 40 more PRs and only 3 maintainers, with their own pace of work 🙂. I'm slowly back into Fixer after a busy...

For anyone who would like to pick up this, please take [this feedback](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7378#pullrequestreview-1709706945) into consideration. I won't reopen this PR as the author did not address my review for more...

In short: I like the idea. Just scrolled through diff and fixed code is better IMHO, this is something I would expect it to be. I still need to review...

FYI: I have a busy time again, and can't focus on Fixer as much as I would like to. I am up to date with issues and PRs, I take...

Every review is helpful, especially from people already familiar with the codebase 😊. Feel free to do it if you have time and will.

As I already mentioned, I would prefer `import_symbols` to be `bool` or `['classes' => true, 'constants' => true, 'functions' => true, 'allow_relative' => true]` (all options related to importing grouped...

Hah, I did not run `testFixAll()` locally and it was a mistake 😅. So much regression. Few questions: - do we want to provide fixes for added cases? - are...